Q1 2020 Report

You are viewing an older update. There is a newer update available.
Previous Update: Q1 2020 Report
Hi everyone,

Please find below a list of Luciap activities during the first quarter of 2020:

1. Review of Who (Factomize) complete rewrite of p2p module of factomd

I mentioned in the past that we were doing code reviews, but I realize that non-programmer may not fully realize the extend of that task. For a good review the reviewer needs to read all the code and understand every bits of it as much as if he wrote the code himself; then comment on many aspects of the code: general design, readability, understandability, potential bugs or optimization ideas etc. This is why code reviews are excellent at finding bugs, augmenting code readability and maintenability over time. Which is also why it takes much more time that people probably expect, and I just wanted to take the time to highlight that for once. This review was particularly long because it was an entire module, but it was very pleasant discussing and working through it with @Who. Here's the full list of my beedback:
  1. https://github.com/WhoSoup/factom-p2p/issues/3
  2. https://github.com/WhoSoup/factom-p2p/issues/4
  3. https://github.com/WhoSoup/factom-p2p/issues/5
  4. https://github.com/WhoSoup/factom-p2p/issues/6
  5. https://github.com/WhoSoup/factom-p2p/issues/7
  6. https://github.com/WhoSoup/factom-p2p/issues/8
  7. https://github.com/WhoSoup/factom-p2p/issues/9
  8. https://github.com/WhoSoup/factom-p2p/pull/10
  9. https://github.com/WhoSoup/factom-p2p/pull/14
  10. https://github.com/WhoSoup/factom-p2p/issues/15
  11. https://github.com/WhoSoup/factom-p2p/issues/16
  12. https://github.com/WhoSoup/factom-p2p/issues/17
  13. https://github.com/WhoSoup/factom-p2p/issues/18
  14. https://github.com/WhoSoup/factom-p2p/issues/19
  15. https://github.com/WhoSoup/factom-p2p/issues/20
  16. https://github.com/WhoSoup/factom-p2p/issues/22
  17. https://github.com/WhoSoup/factom-p2p/pull/23 (comments)
  18. https://github.com/WhoSoup/factom-p2p/issues/24
  19. https://github.com/WhoSoup/factom-p2p/pull/27
  20. https://github.com/WhoSoup/factom-p2p/issues/28
  21. https://github.com/WhoSoup/factom-p2p/issues/30
  22. https://github.com/WhoSoup/factom-p2p/issues/31
  23. https://github.com/WhoSoup/factom-p2p/pull/32
  24. https://github.com/WhoSoup/factom-p2p/issues/33
  25. https://github.com/WhoSoup/factom-p2p/pull/39 (comments)
  26. https://github.com/WhoSoup/factom-p2p/pull/41 (comments)
2. PegNet core contributions

I reviewed PegNet code and reported 2 bugs: https://github.com/pegnet/pegnet/issues/352 and https://github.com/pegnet/pegnet/issues/353 (and fixed one of them). I was also the only one taking the time to review an external contributor work here: https://github.com/pegnet/LXRHash/pull/71.

3. Published a new minor version of the FAT Wallet

@David Kuiper brought to my attention that the FAT Wallet had a different key derivation scheme than MyFactomWallet when interacting with the Ledger device. While not fundamentally an issue for FAT Wallet users, it was still unfortunate and I agreed that having compatibility between our ecosystem tools (MFW and FAT Wallet) was important. I published a new version of the FAT Wallet that can produce compatible keys and that has already helped 2 users who can't use MFW on Windows. Note that we do not have any "FAT continuation grant" on-going and that work was happily done on ANO income. https://github.com/Factom-Asset-Tokens/wallet..

4. factom.js updates

@Alex submitted some good improvements to some features of factom.js (FactomEventEmitter). I reviewed, merged and published those changes.
I also edited the lib to support continuous testing of the testnet: https://github.com/PaulBernier/factomjs/issues/14

5. Participation in the core committee

I remain an active member of the core committee.

6. Orax

We continue to operate and maintain Orax (at a loss), the biggest public PegNet mining pool with over 120 active users.
Last edited:
You are viewing an older update. There is a newer update available.